SAML module allows static links to load the page without full context

Description

Description:

With ACS 6.2.2 and SAML module 1.2.1, the embedded workflow links sent from ACS allow a user to complete a workflow but then either an error is shown (when using Firefox) or the user is taken to the IDP page (when using Chrome).

In 2017 https://alfresco.atlassian.net/browse/MNT-18772 was logged against SAML module 1.0.1 and ACS 5.2.
The outcome was "that any change to this functionality presents a potential risk that could impact multiple customers. There is also a simple work-around. The issue is being closed as a result".

*The behaviour has slightly changed since then and the static links that used to redirect to the document library, now, with ACS 6.2.2 and SAML module 1.2.1, take you to the correct page (the workflow page) but upon completing the workflow, you are shown an error in Firefox or the IDP page in Chrome.
*
Since a fix is not an option, the request is to have the user either be redirected to the document library or to the dashboard.

Steps to reproduce:

1 Setup ACS 6.2.2.
2 Setup outbound email.
3 Install SAML module 1.2.1.
4 Login to Share.
5 In the My Tasks dashlet click Start a Workflow.
6 Select Review and Approve (Single Reviewer).
7 Add a reviewer (can be the logged user).
8 Leave the "Send email notification" ticked.
9 Start the Workflow.
10 Logoff Share.
11 Close the browser.
12 Open the email and click the embedded workflow link (or use http[s]://host:port/share/page/task-edit?taskId=activiti$your_task_number).
13 If SSO is not setup, enter the login details.
14 In the Review page click Approve.
.
Observed behaviour:

Workflow is set as completed and saved.
User is redirected to the IDP page when using Chrome (Error page with Firefox).

Expected behaviour:

Workflow is set as completed and saved.
User is redirected to the Dashboard.

Notes:

The functionality (access static links before the login -> complete the workflow -> end up in the dashboard) seems to work correctly with AIMS.

Environment

None

Testcase ID

None

Assignee

Unassigned

Reporter

Marco Tonelli

Labels

None

Escalated By

None

Security Issue

None

ACT Numbers

01019471

Premier Customer

None

Code Branch

None

Build Location

None

Regression Since

None

Work Funnel End

None

Patch Attached

None

Dependent Version/s

None

Cloud or Enterprise

None

Prioritization Score

None

Delivery Team

None

Bug Priority

Category 3

Components

Fix versions

Affects versions